Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change target framework for source-build #3188

Closed

Conversation

MichaelSimons
Copy link
Member

related to dotnet/source-build#2626

This PR reverts two changes made with #3077 which introduces prebuilts into source-build.

@MichaelSimons
Copy link
Member Author

cc @dseefeld, @Haplois

@Haplois
Copy link
Contributor

Haplois commented Nov 30, 2021

@MichaelSimons, source build fails with this change; I am missing something? Can you take a look?

@zhongjie-cai
Copy link

Could anyone double check on this? Many teams are relying on the VSTest step in their ADO and this is blocking them from migrating to dotnet 6. Thanks!

@lbussell
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 3188 in repo microsoft/vstest

lbussell pushed a commit to lbussell/vstest that referenced this pull request Jan 27, 2022
This patch removes prebuilts caused from targetting netcoreapp1.0

Backported with microsoft#3188
@MichaelSimons
Copy link
Member Author

Superseded by #3285.

@MichaelSimons MichaelSimons deleted the source-build-prebuilts branch January 27, 2022 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants